From 05f19f4ac001b46037bc28bbec3ee219291b596b Mon Sep 17 00:00:00 2001 From: Marcus Minhorst Date: Sun, 27 Jul 2025 15:37:41 -0400 Subject: [PATCH] Fixed oob array access when using m_use_mouse=1 --- wadsrc/static/zscript/engine/ui/menu/optionmenu.zs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/wadsrc/static/zscript/engine/ui/menu/optionmenu.zs b/wadsrc/static/zscript/engine/ui/menu/optionmenu.zs index f39aa8f26..944e777b1 100644 --- a/wadsrc/static/zscript/engine/ui/menu/optionmenu.zs +++ b/wadsrc/static/zscript/engine/ui/menu/optionmenu.zs @@ -628,7 +628,7 @@ class OptionMenu : Menu } } - if (!mDesc.mItems[i].Visible()) + if (i < 0 || !mDesc.mItems[i].Visible()) { continue; } @@ -639,9 +639,10 @@ class OptionMenu : Menu { if (i != mDesc.mSelectedItem) { + mDesc.mSelectedItem = i; + bool silentHover = Cvar.FindCVar("silence_menu_hover").getInt(); if (!silentHover) MenuSound ("menu/cursor"); - mDesc.mSelectedItem = i; } mDesc.mItems[i].MouseEvent(type, x, y); return true;