From 274951839aa0d7fdb74b119fa83ff28215a5ea3b Mon Sep 17 00:00:00 2001
From: "alexey.lysiuk" <alexey.lysiuk@gmail.com>
Date: Sun, 5 Nov 2017 13:15:42 +0200
Subject: [PATCH] Removed unused parameter from several functions in
 FStateDefinitions class
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

src/p_states.cpp:724:54: warning: parameter ‘actor’ set but not used [-Wunused-but-set-parameter]
https://forum.zdoom.org/viewtopic.php?t=58364
---
 src/info.cpp             |  6 ++----
 src/p_states.cpp         | 18 ++++++++----------
 src/scripting/thingdef.h |  6 +++---
 3 files changed, 13 insertions(+), 17 deletions(-)

diff --git a/src/info.cpp b/src/info.cpp
index 94b263105..28feeb826 100644
--- a/src/info.cpp
+++ b/src/info.cpp
@@ -322,18 +322,16 @@ bool PClassActor::SetReplacement(FName replaceName)
 
 void AActor::Finalize(FStateDefinitions &statedef)
 {
-	AActor *defaults = this;
-
 	try
 	{
-		statedef.FinishStates(GetClass(), defaults);
+		statedef.FinishStates(GetClass());
 	}
 	catch (CRecoverableError &)
 	{
 		statedef.MakeStateDefines(nullptr);
 		throw;
 	}
-	statedef.InstallStates(GetClass(), defaults);
+	statedef.InstallStates(GetClass(), this);
 	statedef.MakeStateDefines(nullptr);
 }
 
diff --git a/src/p_states.cpp b/src/p_states.cpp
index 8ec19e653..a330bec76 100644
--- a/src/p_states.cpp
+++ b/src/p_states.cpp
@@ -721,7 +721,7 @@ void FStateDefinitions::RetargetStates (intptr_t count, const char *target)
 //
 //==========================================================================
 
-FState *FStateDefinitions::ResolveGotoLabel (AActor *actor, PClassActor *mytype, char *name)
+FState *FStateDefinitions::ResolveGotoLabel (PClassActor *mytype, char *name)
 {
 	PClassActor *type = mytype;
 	FState *state;
@@ -741,7 +741,6 @@ FState *FStateDefinitions::ResolveGotoLabel (AActor *actor, PClassActor *mytype,
 		if (stricmp (classname, "Super") == 0)
 		{
 			type = ValidateActor(type->ParentClass);
-			actor = GetDefaultByType(type);
 		}
 		else
 		{
@@ -763,7 +762,6 @@ FState *FStateDefinitions::ResolveGotoLabel (AActor *actor, PClassActor *mytype,
 			if (type != stype)
 			{
 				type = static_cast<PClassActor *>(stype);
-				actor = GetDefaultByType (type);
 			}
 		}
 	}
@@ -836,16 +834,16 @@ void FStateDefinitions::FixStatePointers (PClassActor *actor, TArray<FStateDefin
 //
 //==========================================================================
 
-void FStateDefinitions::ResolveGotoLabels (PClassActor *actor, AActor *defaults, TArray<FStateDefine> & list)
+void FStateDefinitions::ResolveGotoLabels (PClassActor *actor, TArray<FStateDefine> & list)
 {
 	for (unsigned i = 0; i < list.Size(); i++)
 	{
 		if (list[i].State != NULL && list[i].DefineFlags == SDF_LABEL)
 		{ // It's not a valid state, so it must be a label string. Resolve it.
-			list[i].State = ResolveGotoLabel (defaults, actor, (char *)list[i].State);
+			list[i].State = ResolveGotoLabel (actor, (char *)list[i].State);
 			list[i].DefineFlags = SDF_STATE;
 		}
-		if (list[i].Children.Size() > 0) ResolveGotoLabels(actor, defaults, list[i].Children);
+		if (list[i].Children.Size() > 0) ResolveGotoLabels(actor, list[i].Children);
 	}
 }
 
@@ -1004,7 +1002,7 @@ int FStateDefinitions::AddStates(FState *state, const char *framechars, const FS
 //
 //==========================================================================
 
-int FStateDefinitions::FinishStates(PClassActor *actor, AActor *defaults)
+int FStateDefinitions::FinishStates(PClassActor *actor)
 {
 	int count = StateArray.Size();
 
@@ -1023,7 +1021,7 @@ int FStateDefinitions::FinishStates(PClassActor *actor, AActor *defaults)
 		FixStatePointers(actor, StateLabels);
 
 		// Fix state pointers that are gotos
-		ResolveGotoLabels(actor, defaults, StateLabels);
+		ResolveGotoLabels(actor, StateLabels);
 
 		for (i = 0; i < count; i++)
 		{
@@ -1047,7 +1045,7 @@ int FStateDefinitions::FinishStates(PClassActor *actor, AActor *defaults)
 				break;
 
 			case SDF_LABEL:
-				realstates[i].NextState = ResolveGotoLabel(defaults, actor, (char *)realstates[i].NextState);
+				realstates[i].NextState = ResolveGotoLabel(actor, (char *)realstates[i].NextState);
 				break;
 			}
 		}
@@ -1055,7 +1053,7 @@ int FStateDefinitions::FinishStates(PClassActor *actor, AActor *defaults)
 	else
 	{
 		// Fix state pointers that are gotos
-		ResolveGotoLabels(actor, defaults, StateLabels);
+		ResolveGotoLabels(actor, StateLabels);
 	}
 	return count;
 }
diff --git a/src/scripting/thingdef.h b/src/scripting/thingdef.h
index 29e648797..0d59dce5c 100644
--- a/src/scripting/thingdef.h
+++ b/src/scripting/thingdef.h
@@ -113,9 +113,9 @@ class FStateDefinitions
 	FStateDefine *FindStateAddress(const char *name);
 	FState *FindState(const char *name);
 
-	FState *ResolveGotoLabel(AActor *actor, PClassActor *mytype, char *name);
+	FState *ResolveGotoLabel(PClassActor *mytype, char *name);
 	static void FixStatePointers(PClassActor *actor, TArray<FStateDefine> & list);
-	void ResolveGotoLabels(PClassActor *actor, AActor *defaults, TArray<FStateDefine> & list);
+	void ResolveGotoLabels(PClassActor *actor, TArray<FStateDefine> & list);
 public:
 
 	FStateDefinitions()
@@ -129,7 +129,7 @@ public:
 	void AddStateLabel(const char *statename);
 	int GetStateLabelIndex (FName statename);
 	void InstallStates(PClassActor *info, AActor *defaults);
-	int FinishStates(PClassActor *actor, AActor *defaults);
+	int FinishStates(PClassActor *actor);
 
 	void MakeStateDefines(const PClassActor *cls);
 	void AddStateDefines(const FStateLabels *list);