From 6f8ca2eace1ca5ea346d4c3d4c475d104826065b Mon Sep 17 00:00:00 2001 From: Christoph Oelckers Date: Sat, 10 Mar 2018 20:47:17 +0100 Subject: [PATCH] - fixed a few issues from implicit FileReader conversion. --- src/files.h | 2 +- src/sound/i_soundfont.cpp | 12 +++++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/files.h b/src/files.h index b40526c2c..dc7022882 100644 --- a/src/files.h +++ b/src/files.h @@ -514,7 +514,7 @@ public: FileRdr() {} // These two functions are only needed as long as the FileReader has not been fully replaced throughout the code. - FileRdr(FileReader *r) + explicit FileRdr(FileReader *r) { mReader = r; } diff --git a/src/sound/i_soundfont.cpp b/src/sound/i_soundfont.cpp index e80726110..1416e380e 100644 --- a/src/sound/i_soundfont.cpp +++ b/src/sound/i_soundfont.cpp @@ -119,11 +119,12 @@ FSF2Reader::FSF2Reader(const char *fn) FileRdr FSF2Reader::OpenMainConfigFile() { + FileRdr fr; if (mMainConfigForSF2.IsNotEmpty()) { - return new MemoryReader(mMainConfigForSF2.GetChars(), (long)mMainConfigForSF2.Len()); + fr.OpenMemory(mMainConfigForSF2.GetChars(), mMainConfigForSF2.Len()); } - return nullptr; + return fr; } FileRdr FSF2Reader::OpenFile(const char *name) @@ -159,15 +160,16 @@ FileRdr FZipPatReader::OpenMainConfigFile() FileRdr FZipPatReader::OpenFile(const char *name) { + FileRdr fr; if (resf != nullptr) { auto lump = resf->FindLump(name); if (lump != nullptr) { - return lump->NewReader(); + return FileRdr(lump->NewReader()); // temporary workaround } } - return nullptr; + return fr; } //========================================================================== @@ -258,7 +260,7 @@ FLumpPatchSetReader::FLumpPatchSetReader(const char *filename) FileRdr FLumpPatchSetReader::OpenMainConfigFile() { - return Wads.ReopenLumpNum(mLumpIndex); + return Wads.ReopenLumpReader(mLumpIndex); } FileRdr FLumpPatchSetReader::OpenFile(const char *name)