From 8597c9e326d1ccaa8b8e0c222d4b18793c1de9e6 Mon Sep 17 00:00:00 2001
From: "alexey.lysiuk" <alexey.lysiuk@gmail.com>
Date: Thu, 1 Nov 2018 16:05:27 +0200
Subject: [PATCH] - added warning for constant conditional expression

ZScript code like `if (x = 0) // ...` no longer causes assertion failure in Debug but produces a warning regadless of configuration

https://forum.zdoom.org/viewtopic.php?t=62422
---
 src/scripting/backend/codegen.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/scripting/backend/codegen.cpp b/src/scripting/backend/codegen.cpp
index 0055c656b..b6059a49c 100644
--- a/src/scripting/backend/codegen.cpp
+++ b/src/scripting/backend/codegen.cpp
@@ -382,7 +382,11 @@ void FxExpression::EmitCompare(VMFunctionBuilder *build, bool invert, TArray<siz
 {
 	ExpEmit op = Emit(build);
 	ExpEmit i;
-	assert(op.RegType != REGT_NIL && op.RegCount == 1 && !op.Konst);
+	assert(op.RegType != REGT_NIL && op.RegCount == 1);
+	if (op.Konst)
+	{
+		ScriptPosition.Message(MSG_WARNING, "Conditional expression is constant");
+	}
 	switch (op.RegType)
 	{
 	case REGT_INT: