From f48e0280d8131ad09ee4a2e0ff311b236924bf27 Mon Sep 17 00:00:00 2001 From: Christoph Oelckers Date: Sat, 30 Mar 2019 09:25:48 +0100 Subject: [PATCH] - fixed: OptionMenuItemSafeCommand did not allow unsafe commands. --- wadsrc/static/zscript/ui/menu/optionmenuitems.zs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/wadsrc/static/zscript/ui/menu/optionmenuitems.zs b/wadsrc/static/zscript/ui/menu/optionmenuitems.zs index c4b65a46d..faaa39a12 100644 --- a/wadsrc/static/zscript/ui/menu/optionmenuitems.zs +++ b/wadsrc/static/zscript/ui/menu/optionmenuitems.zs @@ -179,7 +179,7 @@ class OptionMenuItemCommand : OptionMenuItemSubmenu override bool Activate() { - // This needs to perform a few checks to prevent abuse by malicious modders. + // This needs to perform a few checks to prevent abuse by malicious modders. if (GetClass() != "OptionMenuItemSafeCommand") { let m = OptionMenu(Menu.GetCurrentMenu()); @@ -188,6 +188,7 @@ class OptionMenuItemCommand : OptionMenuItemSubmenu // don't execute if this item cannot be found in the current menu. if (m.GetItem(mAction) != self) return false; } + else mUnsafe = false; Menu.MenuSound("menu/choose"); DoCommand(ccmd, mUnsafe); if (mCloseOnSelect)