OrdinaryMagician/vkdoom_m
OrdinaryMagician/vkdoom_m
1
Fork 0
Code Activity

- Fixed: Timidity::Channel::mono, rpn, and nrpn were not initialized. In

Browse source 
particular, this meant that every channel was almost certainly in mono mode,
  which can sound pretty bad if the song isn't meant to be played that way.
- Added bank numbers to the MIDI precaching for Timidity, since I guess I do
  need to care about banks, if even the Duke MIDIs use various banks.
- Fixed: snd_midiprecache only exists in Win32 builds, so gameconfigfile.cpp
  shouldn't unconditionally link against it.
- Fixed: pre_resample() was still disabled, and it left two samples at the end
  of the new wave data uninitialized.


SVN r903 (trunk)
This commit is contained in:
Randy Heit 2008-04-12 05:04:37 +00:00
commit 0d18580ff0
14 changed files with 178 additions and 99 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/timidity/playmidi.cpp
View file

@ -247,6 +247,9 @@ void Renderer::reset_controllers(int c)
channel[c].sustain = 0;
channel[c].pitchbend = 0x2000;
channel[c].pitchfactor = 0; /* to be computed */
channel[c].mono = 0;
channel[c].rpn = RPN_RESET;
channel[c].nrpn = RPN_RESET;
channel[c].reverberation = 0;
channel[c].chorusdepth = 0;
@ -880,7 +883,7 @@ void Renderer::start_note(int ch, int this_note, int this_velocity, int i)
ip = lp->instrument;
if (ip->type == INST_GUS && ip->samples != 1)
{
ctl->cmsg(CMSG_WARNING, VERB_VERBOSE,
cmsg(CMSG_WARNING, VERB_VERBOSE,
"Strange: percussion instrument with %d samples!", ip->samples);
}
@ -1257,7 +1260,7 @@ void Renderer::note_off(int chan, int note, int vel)
void Renderer::all_notes_off(int c)
{
int i = voices;
ctl->cmsg(CMSG_INFO, VERB_DEBUG, "All notes off on channel %d", c);
cmsg(CMSG_INFO, VERB_DEBUG, "All notes off on channel %d", c);
while (i--)
{
if (voice[i].status == VOICE_ON && voice[i].channel == c)