- Am I the only one who thinks that static_casts can create really clunky code? (Thanks, GCC, for your overly paranoid warning settings that necessitate such ugliness. :( )

SVN r2844 (trunk)
This commit is contained in:
Christoph Oelckers 2010-09-22 06:52:48 +00:00
commit 16fa8cc249
7 changed files with 18 additions and 15 deletions

View file

@ -796,13 +796,13 @@ void DPlayerMenu::UpdateSkins()
else
{
PlayerSkins.Clear();
for(unsigned i=0;i<(unsigned)numskins; i++)
for(int i=0;i<(int)numskins; i++)
{
if (PlayerClass->CheckSkin(i))
{
int j = PlayerSkins.Push(i);
li->SetString(j, skins[i].name);
if (static_cast<unsigned int> (players[consoleplayer].userinfo.skin) == i)
if (players[consoleplayer].userinfo.skin == i)
{
sel = j;
}