- got rid of FileSystem::GetFileData.

Using FMemFile is better in all these places.

src/common/audio/music/i_music.cpp

@@ -179,11 +179,10 @@ static void SetupGenMidi()
 		Printf("No GENMIDI lump found. OPL playback not available.\n");
 		return;
 	}
-	auto data = fileSystem.OpenFileReader(lump);
+	auto genmidi = fileSystem.ReadFile(lump);
 
-	auto genmidi = data.Read();
-	if (genmidi.size() < 8 + 175 * 36 || memcmp(genmidi.data(), "#OPL_II#", 8)) return;
-	ZMusic_SetGenMidi(genmidi.data()+8);
+	if (genmidi.GetSize() < 8 + 175 * 36 || memcmp(genmidi.GetMem(), "#OPL_II#", 8)) return;
+	ZMusic_SetGenMidi((uint8_t*)genmidi.GetString().GetChars() + 8);
 }
 
 static void SetupWgOpn()

src/common/engine/sc_man.cpp

@@ -136,7 +136,7 @@ void FScanner::Open (const char *name)
 //
 // FScanner :: OpenFile
 //
-// Loads a script from a file. Uses new/delete for memory allocation.
+// Loads a script from a file.
 //
 //==========================================================================
 

src/common/engine/stringtable.cpp

@@ -60,10 +60,10 @@ void FStringTable::LoadStrings (const char *language)
 	lastlump = 0;
 	while ((lump = fileSystem.FindLump ("LANGUAGE", &lastlump)) != -1)
 	{
-		auto lumpdata = fileSystem.GetFileData(lump);
+		auto lumpdata = fileSystem.ReadFile(lump);
 
-		if (!ParseLanguageCSV(lump, lumpdata))
- 			LoadLanguage (lump, lumpdata);
+		if (!ParseLanguageCSV(lump, lumpdata.GetString(), lumpdata.GetSize()))
+ 			LoadLanguage (lump, lumpdata.GetString(), lumpdata.GetSize());
 	}
 	UpdateLanguage(language);
 	allMacros.Clear();
@@ -77,9 +77,9 @@ void FStringTable::LoadStrings (const char *language)
 //==========================================================================
 
 
-TArray<TArray<FString>> FStringTable::parseCSV(const TArray<uint8_t> &buffer)
+TArray<TArray<FString>> FStringTable::parseCSV(const char* buffer, size_t size)
 {
-	const size_t bufLength = buffer.Size();
+	const size_t bufLength = size;
 	TArray<TArray<FString>> data;
 	TArray<FString> row;
 	TArray<char> cell;
@@ -158,8 +158,8 @@ TArray<TArray<FString>> FStringTable::parseCSV(const TArray<uint8_t> &buffer)
 
 bool FStringTable::readMacros(int lumpnum)
 {
-	auto lumpdata = fileSystem.GetFileData(lumpnum);
-	auto data = parseCSV(lumpdata);
+	auto lumpdata = fileSystem.ReadFile(lumpnum);
+	auto data = parseCSV(lumpdata.GetString(), lumpdata.GetSize());
 
 	for (unsigned i = 1; i < data.Size(); i++)
 	{
@@ -186,11 +186,11 @@ bool FStringTable::readMacros(int lumpnum)
 //
 //==========================================================================
 
-bool FStringTable::ParseLanguageCSV(int lumpnum, const TArray<uint8_t> &buffer)
+bool FStringTable::ParseLanguageCSV(int lumpnum, const char* buffer, size_t size)
 {
-	if (buffer.Size() < 11) return false;
-	if (strnicmp((const char*)buffer.Data(), "default,", 8) && strnicmp((const char*)buffer.Data(), "identifier,", 11 )) return false;
-	auto data = parseCSV(buffer);
+	if (size < 11) return false;
+	if (strnicmp(buffer, "default,", 8) && strnicmp(buffer, "identifier,", 11 )) return false;
+	auto data = parseCSV(buffer, size);
 
 	int labelcol = -1;
 	int filtercol = -1;
@@ -282,14 +282,14 @@ bool FStringTable::ParseLanguageCSV(int lumpnum, const TArray<uint8_t> &buffer)
 //
 //==========================================================================
 
-void FStringTable::LoadLanguage (int lumpnum, const TArray<uint8_t> &buffer)
+void FStringTable::LoadLanguage (int lumpnum, const char* buffer, size_t size)
 {
 	bool errordone = false;
 	TArray<uint32_t> activeMaps;
 	FScanner sc;
 	bool hasDefaultEntry = false;
 
-	sc.OpenMem("LANGUAGE", buffer);
+	sc.OpenMem("LANGUAGE", buffer, (int)size);
 	sc.SetCMode (true);
 	while (sc.GetString ())
 	{

src/common/engine/stringtable.h

@@ -44,6 +44,7 @@
 
 
 #include <stdlib.h>
+#include <vector>
 #include "basics.h"
 #include "zstring.h"
 #include "tarray.h"
@@ -111,11 +112,10 @@ private:
 	LangMap allStrings;
 	TArray<std::pair<uint32_t, StringMap*>> currentLanguageSet;
 
-	void LoadLanguage (int lumpnum, const TArray<uint8_t> &buffer);
-	TArray<TArray<FString>> parseCSV(const TArray<uint8_t> &buffer);
-	bool ParseLanguageCSV(int lumpnum, const TArray<uint8_t> &buffer);
+	void LoadLanguage (int lumpnum, const char* buffer, size_t size);
+	TArray<TArray<FString>> parseCSV(const char* buffer, size_t size);
+	bool ParseLanguageCSV(int lumpnum, const char* buffer, size_t size);
 
-	bool LoadLanguageFromSpreadsheet(int lumpnum, const TArray<uint8_t> &buffer);
 	bool readMacros(int lumpnum);
 	void DeleteString(int langid, FName label);
 	void DeleteForLabel(int lumpnum, FName label);

src/common/filesystem/filesystem.cpp

@@ -1294,32 +1294,6 @@ unsigned FileSystem::GetFilesInFolder(const char *inpath, TArray<FolderEntry> &r
 	return result.Size();
 }
 
-//==========================================================================
-//
-// GetFileData
-//
-// Loads the lump into a TArray and returns it.
-//
-//==========================================================================
-
-TArray<uint8_t> FileSystem::GetFileData(int lump, int pad)
-{
-	if ((size_t)lump >= FileInfo.Size())
-		return TArray<uint8_t>();
-
-	auto lumpr = OpenFileReader(lump);
-	auto size = lumpr.GetLength();
-	TArray<uint8_t> data(size + pad, true);
-	auto numread = lumpr.Read(data.Data(), size);
-
-	if (numread != size)
-	{
-		throw FileSystemException("GetFileData: only read %ld of %ld on lump %i\n",
-			numread, size, lump);
-	}
-	if (pad > 0) memset(&data[size], 0, pad);
-	return data;
-}
 //==========================================================================
 //
 // W_ReadFile
@@ -1352,7 +1326,7 @@ void FileSystem::ReadFile (int lump, void *dest)
 
 FileData FileSystem::ReadFile (int lump)
 {
-	return FileData(FString(ELumpNum(lump)));
+	return FileData(FString(*this, ELumpNum(lump)));
 }
 
 //==========================================================================
@@ -1578,7 +1552,7 @@ FileData::~FileData ()
 {
 }
 
-FString::FString (ELumpNum lumpnum)
+FString::FString (FileSystem& fileSystem, ELumpNum lumpnum)
 {
 	auto lumpr = fileSystem.OpenFileReader ((int)lumpnum);
 	auto size = lumpr.GetLength ();

src/common/filesystem/filesystem.h

@@ -125,16 +125,10 @@ public:
 	inline int GetNumForFullName (const FString &name) { return GetNumForFullName(name.GetChars()); }
 
 	void ReadFile (int lump, void *dest);
-	TArray<uint8_t> GetFileData(int lump, int pad = 0);	// reads lump into a writable buffer and optionally adds some padding at the end. (FileData isn't writable!)
+	// These should only be used if the file data really needs padding.
 	FileData ReadFile (int lump);
 	FileData ReadFile (const char *name) { return ReadFile (GetNumForName (name)); }
-
-	inline TArray<uint8_t> LoadFile(const char* name, int padding = 0)
-	{
-		auto lump = FindFile(name);
-		if (lump < 0) return TArray<uint8_t>();
-		return GetFileData(lump, padding);
-	}
+	FileData ReadFileFullName(const char* name) { return ReadFile(GetNumForFullName(name)); }
 
 	FileReader OpenFileReader(int lump);		// opens a reader that redirects to the containing file's one.
 	FileReader ReopenFileReader(int lump, bool alwayscache = false);		// opens an independent reader.

src/common/textures/formats/qoitexture.cpp

@@ -140,15 +140,15 @@ int FQOITexture::CopyPixels(FBitmap *bmp, int conversion)
 
 	constexpr auto QOI_COLOR_HASH = [](PalEntry C) { return (C.r * 3 + C.g * 5 + C.b * 7 + C.a * 11); };
 
-	auto lump = fileSystem.OpenFileReader(SourceLump);
-	auto bytes = lump.Read();
-	if (bytes.size() < 22) return 0;	// error
+	auto lump = fileSystem.ReadFile(SourceLump);
+	if (lump.GetSize() < 22) return 0;	// error
 	PalEntry index[64] = {};
 	PalEntry pe = 0xff000000;
 
 	size_t p = 14, run = 0;
 
-	size_t chunks_len = bytes.size() - 8;
+	size_t chunks_len = lump.GetSize() - 8;
+	auto bytes = (const uint8_t*)lump.GetMem();
 
 	for (int h = 0; h < Height; h++)
 	{

src/common/utility/zstring.h

@@ -117,6 +117,8 @@ enum ELumpNum
 {
 };
 
+class FileSystem;
+
 class FString
 {
 public:
@@ -146,7 +148,7 @@ public:
 	FString (char head, const FString &tail);
 
 	// Other constructors
-	FString (ELumpNum);	// Create from a lump
+	FString (FileSystem&, ELumpNum);	// Create from a lump
 
 	~FString ();