OrdinaryMagician/vkdoom_m
OrdinaryMagician/vkdoom_m
1
Fork 0
Code Activity

- immediately abort loading a savegame if object deserialization fails.

Browse source 
If the loader is allowed to go on, these objects will be linked into game structures and may do unpredictable things before the loader has a chance to abort at the end.
This commit is contained in:
Christoph Oelckers 2020-09-26 20:36:10 +02:00
commit 668ebd9be1
3 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/p_saveg.cpp
View file

@ -956,6 +956,8 @@ void FLevelLocals::Serialize(FSerializer &arc, bool hubload)
Thinkers.DestroyAllThinkers();
interpolator.ClearInterpolations();
arc.ReadObjects(hubload);
// If there have been object deserialization errors we must absolutely not continue here because scripted objects can do unpredictable things.
if (arc.mObjectErrors) I_Error("Failed to load savegame");
}
arc("multiplayer", multiplayer);