OrdinaryMagician/vkdoom_m
OrdinaryMagician/vkdoom_m
1
Fork 0
Code Activity

- don't put mutexes into static local variables.

Browse source 
Their initialization semantics are not safe for synchronization objects.
This commit is contained in:
Christoph Oelckers 2018-12-08 11:56:31 +01:00
commit 92b722e0ee
3 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/swrenderer/r_renderthread.cpp
View file

@ -89,6 +89,7 @@ namespace swrenderer
return pal_drawers.get();
}
static std::mutex loadmutex;
void RenderThread::PrepareTexture(FTexture *texture, FRenderStyle style)
{
if (texture == nullptr)
@ -102,8 +103,6 @@ namespace swrenderer
// It is critical that this function is called before any direct
// calls to GetPixels for this to work.
static std::mutex loadmutex;
std::unique_lock<std::mutex> lock(loadmutex);
texture->GetPixels(style);
@ -116,10 +115,9 @@ namespace swrenderer
}
}
static std::mutex polyobjmutex;
void RenderThread::PreparePolyObject(subsector_t *sub)
{
static std::mutex polyobjmutex;
std::unique_lock<std::mutex> lock(polyobjmutex);
if (sub->BSP == nullptr || sub->BSP->bDirty)