- Fixed: The check for no skill menu was incorrect when a custom player

class menu was present so instead of starting the game specific skill menu
  it always started Hexen's.
- Fixed: When a non-player tried to play a player sound it tried to access 
  the actor object as an APlayerPawn.
- Changed PlayAttacking2 to always use the melee state instead of different
  implementations per player and hard coding it to MissileState+1. Also
  changed PlayAttacking for the HereticPlayer to use the same animation as
  PlayAttacking2. Now the special handling for Heretic in the FireWeapon
  functions can be removed.

For R258:

- Fixed: PlayerStartItem created a duplicate of the item's class name before
  converting it into an FName.
- Removed game check for Doom from P_BloodSplatter. The BloodSplatter actor
  is compatible with all games now so the explicit handling is no longer needed.
- Moved replacement handling back into AActor::StaticSpawn but controlled
  by a (mandatory) parameter. Also added replacement to most other
  instances in the game where non-inventory items are spawned. Replacement is safe 
  nearly everywhere except for inventory related spawns.
- Fixed: Due to the player class inclusion A_NoBlocking never called
  NoBlockingSet for monsters.
- Changed: Sounds can be specified by full path now in SNDINFO and S_SKIN.


SVN r259 (trunk)

src/g_hexen/a_fighterplayer.cpp

@@ -99,6 +99,7 @@ IMPLEMENT_ACTOR (AFighterPlayer, Hexen, -1, 0)
 	PROP_SeeState (S_FPLAY_RUN)
 	PROP_PainState (S_FPLAY_PAIN)
 	PROP_MissileState (S_FPLAY_ATK)
+	PROP_MeleeState (S_FPLAY_ATK)
 	PROP_DeathState (S_FPLAY_DIE)
 	PROP_XDeathState (S_FPLAY_XDIE)
 	PROP_BDeathState (S_PLAY_F_FDTH)
@@ -120,11 +121,6 @@ IMPLEMENT_ACTOR (AFighterPlayer, Hexen, -1, 0)
 	PROP_PainSound ("PlayerFighterPain")
 END_DEFAULTS
 
-void AFighterPlayer::PlayAttacking2 ()
-{
-	SetState (MissileState);
-}
-
 void AFighterPlayer::GiveDefaultInventory ()
 {
 	Super::GiveDefaultInventory ();