OrdinaryMagician/vkdoom_m
OrdinaryMagician/vkdoom_m
1
Fork 0
Code Activity

removed several bad casts to 'long'.

Browse source 
The 'long' type should generally be avoided because its size differs on Windows and Linux/Mac so it is almost guaranteed to cause undefined behavior
This commit is contained in:
Professor Hastig 2023-10-04 09:58:18 +02:00 • committed by Christoph Oelckers
commit ab8711b57a
15 changed files with 29 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/common/filesystem/source/file_7z.cpp
View file

@ -65,7 +65,7 @@ struct CZDFileInStream
static SRes Read(const ISeekInStream *pp, void *buf, size_t *size)
{
CZDFileInStream *p = (CZDFileInStream *)pp;
auto numread = p->File.Read(buf, (long)*size);
auto numread = p->File.Read(buf, (ptrdiff_t)*size);
if (numread < 0)
{
*size = 0;
@ -96,7 +96,7 @@ struct CZDFileInStream
{
return 1;
}
res = (int)p->File.Seek((long)*pos, move_method);
res = (int)p->File.Seek((ptrdiff_t)*pos, move_method);
*pos = p->File.Tell();
return res;
}