- removed all access to the consoleplayer variable from the play code

There is one exception in ACS for a net arbitrator check.
Aside from this the bot_observer CVAR was also removed. This was never implemented properly and could stomp upon custom player settings.
This commit is contained in:
Christoph Oelckers 2019-02-01 17:02:10 +01:00
commit d358e401ee
16 changed files with 101 additions and 110 deletions

View file

@ -2951,7 +2951,7 @@ FUNC(LS_SetPlayerProperty)
item->ColorVar(NAME_BlendColor) = MakeSpecialColormap(INVERSECOLORMAP);
}
}
else if (it->player - players == consoleplayer)
else if (it->player && it->player == Level->GetConsolePlayer())
{
Level->flags2 |= LEVEL2_ALLMAP;
}
@ -2966,7 +2966,7 @@ FUNC(LS_SetPlayerProperty)
item->Destroy ();
}
}
else if (it->player - players == consoleplayer)
else if (it->player && it->player == Level->GetConsolePlayer())
{
Level->flags2 &= ~LEVEL2_ALLMAP;
}
@ -2992,7 +2992,7 @@ FUNC(LS_SetPlayerProperty)
item->ColorVar(NAME_BlendColor) = MakeSpecialColormap(INVERSECOLORMAP);
}
}
else if (i == consoleplayer)
else if (p == Level->GetConsolePlayer())
{
Level->flags2 |= LEVEL2_ALLMAP;
}
@ -3007,7 +3007,7 @@ FUNC(LS_SetPlayerProperty)
item->Destroy ();
}
}
else if (i == consoleplayer)
else if (p == Level->GetConsolePlayer())
{
Level->flags2 &= ~LEVEL2_ALLMAP;
}