OrdinaryMagician/vkdoom_m
OrdinaryMagician/vkdoom_m
1
Fork 0
Code Activity

- took DCanvas and all its subtypes out of the DObject tree.

Browse source 
I have no idea why they were even in there, as they intentionally circumvented all GC related features - they declared themselves fixed if prone to getting collected, they all used OF_YesReallyDelete when destroying themselves and they never used any of the object creation or RTTI features, aside from a single assert in V_Init2.

Essentially they were a drag on the system and OF_YesReallyDelete was effectively added just to deal with the canvases which were DObjects but not supposed to behave like them in the first place.
This commit is contained in:
Christoph Oelckers 2017-04-14 10:48:18 +02:00
commit dc5a5419fc
21 changed files with 16 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/dobjgc.cpp
View file

@ -326,7 +326,6 @@ static void MarkRoot()
Gray = NULL;
Mark(Args);
Mark(screen);
Mark(StatusBar);
M_MarkMenus();
Mark(DIntermissionController::CurrentIntermission);