- Fixed: The names in the Depths array in m_options.cpp were never freed.

- Fixed: FDoomEdMap needed a destructor.
- Fixed: Decal animators were never freed.
- Fixed: Colormaps were never freed.
- Fixed: Memory allocated in R_InitTranslationTables() was never freed.
- Fixed: R_InitParticles() allocated way more memory than it needed to. (And the
  particle memory was never freed, either.)
- Fixed: FMetaTable::FreeMeta() should use delete[] to free string metadata.
- Fixed: FConfigFile::ClearCurrentSection() must cast the entry to a char *
  before deleting it, because that's the way it was allocated.
- Fixed definitions of DeadZombieMan and DeadShotgunGuy in doom/deadthings.txt.
  Skip_super resets the dropitem list, so having it after "DropItem None" is
  pointless.
- Fixed: Decorate DropItem information was never freed.
- Fixed: FinishStates() allocated even 0-entry state arrays.
- Fixed: Default actor instances were never freed.
- Fixed: FRandomSoundList never freed its sound list.
- Fixed: Level and cluster strings read from MAPINFO were never freed.
- Fixed: Episode names were never freed.
- Fixed: InverseColormap and GoldColormap were never freed. Since they're always
  allocated, they can just be arrays rather than pointers.
- Fixed: FFont destructor never freed any of the character data or the font's name.
- Fixed: Fonts were not freed at exit.
- Fixed: FStringTable::LoadLanguage() did not call SC_Close().
- Fixed: When using the -iwad parameter, IdentifyVersion() did not release the
  buffer it created to hold the parameter's path.


SVN r88 (trunk)

src/s_advsound.cpp

@@ -62,11 +62,31 @@
 
 struct FRandomSoundList
 {
+	FRandomSoundList()
+	: Sounds(0), SfxHead(0), NumSounds(0)
+	{
+	}
+	~FRandomSoundList()
+	{
+		if (Sounds != NULL)
+		{
+			delete[] Sounds;
+			Sounds = NULL;
+		}
+	}
+
 	WORD		*Sounds;	// A list of sounds that can result for the following id
 	WORD		SfxHead;	// The sound id used to reference this list
 	WORD		NumSounds;
 };
 
+template<>
+void CopyForTArray<FRandomSoundList> (FRandomSoundList &dst, FRandomSoundList &src)
+{
+	dst = src;
+}
+
+
 struct FPlayerClassLookup
 {
 	char		Name[MAX_SNDNAME+1];
@@ -540,10 +560,6 @@ static void S_ClearSoundData()
 		if (Ambients[i]) delete Ambients[i];
 		Ambients[i]=NULL;
 	}
-	for(i=0;i<S_rnd.Size();i++)
-	{
-		delete[] S_rnd[i].Sounds;
-	}
 	while (MusicVolumes != NULL)
 	{
 		FMusicVolume * me = MusicVolumes;
@@ -934,10 +950,10 @@ static void S_AddSNDINFO (int lump)
 				else if (list.Size() > 1)
 				{ // Only add non-empty random lists
 					random.NumSounds = (WORD)list.Size();
-					random.Sounds = new WORD[random.NumSounds];
-					memcpy (random.Sounds, &list[0], sizeof(WORD)*random.NumSounds);
 					S_sfx[random.SfxHead].link = (WORD)S_rnd.Push (random);
 					S_sfx[random.SfxHead].bRandomHeader = true;
+					S_rnd[S_sfx[random.SfxHead].link].Sounds = new WORD[random.NumSounds];
+					memcpy (S_rnd[S_sfx[random.SfxHead].link].Sounds, &list[0], sizeof(WORD)*random.NumSounds);
 				}
 				}
 				break;