OrdinaryMagician/vkdoom_m
OrdinaryMagician/vkdoom_m
1
Fork 0
Code Activity

- got rid of FNameNoInit and made the default constructor of FName non-initializing.

Browse source 
This setup has been a constant source of problems so now I reviewed all uses of FName to make sure that everything that needs to be initialized is done manually.
This also merges the player_t constructor into the class definition as default values.
This commit is contained in:
Christoph Oelckers 2018-08-19 01:14:15 +02:00
commit fad406c4c9
47 changed files with 185 additions and 309 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/p_udmf.cpp
View file

@ -462,7 +462,7 @@ class UDMFParser : public UDMFParserBase
TArray<vertex_t> ParsedVertices;
TArray<UDMFScroll> UDMFScrollers;
FDynamicColormap *fogMap, *normMap;
FDynamicColormap *fogMap = nullptr, *normMap = nullptr;
FMissingTextureTracker &missingTex;
public:
@ -470,7 +470,6 @@ public:
: missingTex(missing)
{
linemap.Clear();
fogMap = normMap = NULL;
}
void ReadUserKey(FUDMFKey &ukey) {
@ -1357,11 +1356,11 @@ public:
// Brand new UDMF scroller properties
double scroll_ceil_x = 0;
double scroll_ceil_y = 0;
FName scroll_ceil_type;
FName scroll_ceil_type = NAME_None;
double scroll_floor_x = 0;
double scroll_floor_y = 0;
FName scroll_floor_type;
FName scroll_floor_type = NAME_None;
memset(sec, 0, sizeof(*sec));